[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: getloadavg and LIBOBJDIR
From: |
Jim Meyering |
Subject: |
Re: getloadavg and LIBOBJDIR |
Date: |
Sat, 23 Sep 2006 00:41:32 +0200 |
Bruno Haible <address@hidden> wrote:
> There were no objections in 4 days, so I applied this patch.
Hi Bruno,
Four days wasn't long enough, especially,
since I'm hoping to make a "stable" coreutils release soon.
>> 2006-09-17 Bruno Haible <address@hidden>
>>
>> * gnulib-tool (func_import, func_create_testdir): Set gl_source_base
>> at the beginning of the gl_INIT macro.
>> * m4/getloadavg.m4 (gl_GETLOADAVG): Expect the directory of
>> getloadavg.c as first argument.
>> * modules/getloadavg (configure.ac): Pass $gl_source_base to
>> gl_GETLOADAVG.
That change breaks coreutils' configure.
It happens because of this assignment in configure:
gl_source_base='.#bootmp/lib'
When configure is run, .#bootmp/lib no longer exists, so the
check for existence of getloadavg.c is wrong:
test -f "$srcdir/$gl_source_base/getloadavg.c" ||
{ { echo "$as_me:$LINENO: error: $srcdir/$ac_config_libobj_dir/getloadavg.c
is missing" >&5
Confusingly, the diagnostic says ./lib/getloadavg.c is missing,
(which isn't true) while the preceding test checks
for ./.#bootmp/lib/getloadavg.c.
Jim