bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnulib taking over libobjs?


From: Jim Meyering
Subject: Re: gnulib taking over libobjs?
Date: Thu, 12 Oct 2006 16:15:59 +0200

Bruno Haible <address@hidden> wrote:

> Simon Josefsson wrote:
>> The last patch wasn't working, but this is somewhat better.
>
> This appears to work reasonably well, and I need it also for gettext,
> so I committed it.
> Simon, compared to your proposed patch, I
>   - applied the same change to func_create_testdir as well,
>   - made the backslashing in sed_drop_objext unambiguous,
>   - removed the $(top_builddir)/${sourcebase}/ construct - the variable
>     $(${macro_prefix}_LIBOBJS) is only accessed from the $sourcebase directory
>     and does therefore not need this pathname prefix.
>
> Attention: coreutils needs the following patch, because it mixes AC_LIBOBJs
> from outside the gnulib-tool generated file list with gnulib-tool gl_LIBOBJs
> in the same library.
>
> *** coreutils/lib/Makefile.am     23 Aug 2006 18:37:27 -0000      1.252
> --- coreutils/lib/Makefile.am     12 Oct 2006 12:29:41 -0000
> ***************
> *** 29,34 ****
> --- 29,37 ----
>     xmemcoll.c xmemcoll.h \
>     xmemxfrm.c xmemxfrm.h
>
> + libcoreutils_a_LIBADD += $(LIBOBJS)
> + libcoreutils_a_DEPENDENCIES += $(LIBOBJS)

Thanks for the suggestion, but with or without that change, using
the latest version of gnulib-tool, coreutils now fails to pass "make
distcheck" after a bootstrap.  At least part of the problem is that
lib/Makefile's DIST_COMMON ends up being nearly empty.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]