[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fts.c doesn't compile with C89 compiler
From: |
Jim Meyering |
Subject: |
Re: fts.c doesn't compile with C89 compiler |
Date: |
Wed, 25 Oct 2006 15:18:22 +0200 |
Jim Meyering <address@hidden> wrote:
> Bruno Haible <address@hidden> wrote:
...
>> fts.c:1076: warning: ISO C90 forbids mixed declarations and code
>>
>> gnulib still assumes C89 only. Here is a fix.
>>
>> Jim, OK to apply?
>
> That looks fine.
> Yes, thanks.
Thanks for checking it in.
However, I was surprised to see that your commit log message
was something very brief and not descriptive, like "ANSI C!",
nowhere near as useful as the ChangeLog entry:
* lib/fts.c (fts_build): Move variable declaration, for C89 compliance.
I've changed the log message.
I have found that it is useful to keep the commit log message
very similar to the ChangeLog entry.