bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-gnulib] yet another hello pretest


From: Bruno Haible
Subject: Re: [bug-gnulib] yet another hello pretest
Date: Thu, 9 Nov 2006 17:29:47 +0100
User-agent: KMail/1.9.1

Eric Blake wrote:
> 2006-11-09  Eric Blake  <address@hidden>
> 
>       * hello.c (main): Use atexit, to avoid warning with 'gcc -Wall
>       -Werror'.
>       (my_exit): Delete, no longer needed.
> 

I support this patch. Using 'atexit' leads to more maintainable code
than pervasive use of 'my_exit'.

> Also, you may want to get rid of the space-tab formatting errors in your
> ChangeLog.

Also this one:

--- tests/ChangeLog.bak 2006-08-23 15:45:59.000000000 +0200
+++ tests/ChangeLog     2006-11-09 17:27:58.000000000 +0100
@@ -13,7 +13,7 @@
 
 2006-08-22  Bruno Haible  <address@hidden>
 
-       * greeting-moon: New file.
+       * greeting-2: New file.
        * Makefile.am (TESTS): Add it.
 
 2006-08-13  Karl Berry  <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]