bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils 6.6 HP-UX build error


From: Jim Meyering
Subject: Re: coreutils 6.6 HP-UX build error
Date: Thu, 23 Nov 2006 01:31:04 +0100

Paul Eggert <address@hidden> wrote:
> Jim Meyering <address@hidden> writes:
>> +                enum Fts_stat need_stat = p->fts_statp->st_size;
>> +                switch (need_stat)
>
> Dunno if this matters, but on typical 64-bit platforms converting to
> enum Fts_stat and then switching won't abort in the rare cases when
> p->fts_statp->st_size equals 2**32 + 1 or 2**32 + 2, whereas the
> previous code would correctly abort in those two cases.

Thanks, but that doesn't matter.  When st_size is used that way (when
->fts_info == FTS_NSOK), its value must be FTS_STAT_REQUIRED (1) or
FTS_NO_STAT_REQUIRED (2).  If there is a way to make it have any other
value, it's a bug.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]