bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: getline.h


From: Eric Blake
Subject: Re: getline.h
Date: Wed, 22 Aug 2007 18:04:57 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.6) Gecko/20070728 Thunderbird/2.0.0.6 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Bruno Haible on 8/22/2007 3:02 PM:
> Hi Eric,
> 
> Thanks for working on this, and for the unit tests. The patch - excluding
> the one of getdelim.c - is nearly perfect. But I see three problems:

Thanks for catching the nits.  Please feel free to apply patches if you
come up with them before me.

> 
> 3) This fails to provide a declaration for the rpl_getline function
> if @REPLACE_GETLINE@ && @HAVE_DECL_GETLINE@ (e.g. on all those systems
> which have a getline function which does not work: Cygwin, IRIX).

Actually, cygwin's getline works, as of 1.5.19 (now at 1.5.24); it passed
the test-readline.c requirements just fine.  Unless you have a countercase
where it does not work, in which case we need to beef up the test.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGzM8p84KuGfSFAYARAiuOAJ90hLNFcPQLjAi9zNAQqciuutpsgQCfcroX
+VpLlnU+5OrV3iygzi3hg1c=
=mMr9
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]