[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for the getpagesize module
From: |
Bruno Haible |
Subject: |
Re: Patch for the getpagesize module |
Date: |
Tue, 27 Nov 2007 14:05:06 +0100 |
User-agent: |
KMail/1.9.1 |
Hello Martin,
Thanks for your patch.
> - Don't provide a getpagesize.h header. Modify gnulibs unistd.h
> instead.
Yes, I agree this is useful, because although POSIX does not specify
getpagesize() any more, SUSV2 had it declared in <unistd.h> [1].
> - Provide a getpagesize function (not a macro) if the system does not
> have one.
What is the point of doing that? A function that in most cases just returns
a fixed number can well be inlined. And since 'inline' is a bit tricky to
use portably, we chose to implement it as a macro. What drawbacks do you see
with that?
Bruno
[1] http://www.opengroup.org/onlinepubs/007908775/xsh/getpagesize.html