bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

fseeko and cygwin


From: Eric Blake
Subject: fseeko and cygwin
Date: Sat, 01 Dec 2007 11:54:50 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Cygwin will soon be releasing 1.5.25, which fixes several bugs but adds no
new functions [1].  Therefore, the test for cygwin-specific breakage in
fseeko in 1.5.24 and earlier, which was using a compile-time test that
triggered off of the addition of asnprintf in cygwin CVS head, failed to
catch that the fseeko bug in question is now fixed.  I'm committing this,
which swaps to a different compile-time test of something also fixed for
1.5.25.

[1] http://cygwin.com/ml/cygwin/2007-12/msg00009.html

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHUa3584KuGfSFAYARAjlsAKCf/G8K49YkImB8id9CoA4erFdPXQCeNK0+
EjEJWxt9/Pw5eyemrJIJhmo=
=3aOn
-----END PGP SIGNATURE-----
>From f6db1c2cee50fb3330cac4adf8a1e91f8b649408 Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Sat, 1 Dec 2007 11:53:07 -0700
Subject: [PATCH] Fix fseeko detection for cygwin 1.5.25.

* m4/stdio_h.m4 (gl_STDIN_LARGE_OFFSET) [__CYGWIN__]: Rewrite to
accomodate fix in cygwin 1.5.25.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog     |    5 +++++
 m4/stdio_h.m4 |   16 +++++++++-------
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 374322b..9f3f241 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2007-12-01  Eric Blake  <address@hidden>
+
+       * m4/stdio_h.m4 (gl_STDIN_LARGE_OFFSET) [__CYGWIN__]: Rewrite to
+       accomodate fix in cygwin 1.5.25.
+
 2007-12-01  Jim Meyering  <address@hidden>
 
        Fix a bug that inhibited much of the utf8-optimization in regcomp.c.
diff --git a/m4/stdio_h.m4 b/m4/stdio_h.m4
index 45e54e2..83d48ec 100644
--- a/m4/stdio_h.m4
+++ b/m4/stdio_h.m4
@@ -73,13 +73,15 @@ AC_DEFUN([gl_STDIN_LARGE_OFFSET],
       [AC_LINK_IFELSE([AC_LANG_PROGRAM([#include <stdio.h>],
 [#if defined __SL64 && defined __SCLE /* cygwin */
   /* Cygwin 1.5.24 and earlier fail to put stdin in 64-bit mode, making
-     fseeko/ftello needlessly fail.  This bug was fixed at the same time
-     that cygwin started exporting asnprintf (cygwin 1.7.0), so we use
-     that as a link-time test for cross-compiles rather than building
-     a runtime test.  */
-  size_t s;
-  if (asnprintf (NULL, &s, ""))
-    return 0;
+     fseeko/ftello needlessly fail.  This bug was fixed in 1.5.25, at the
+     same time that cygwin fixed the declaration of "long timezone" to no
+     longer be a macro, so we use that as a compile-time test for
+     cross-compiles rather than building a runtime test.  */
+# define timezonevar
+# include <sys/time.h>
+# ifdef timezone
+  choke me
+# endif
 #endif])],
        [gl_cv_var_stdin_large_offset=yes],
        [gl_cv_var_stdin_large_offset=no])])
-- 
1.5.3.5


reply via email to

[Prev in Thread] Current Thread [Next in Thread]