[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GNUmakefile and 'make install'
From: |
Eric Blake |
Subject: |
Re: GNUmakefile and 'make install' |
Date: |
Mon, 21 Jul 2008 21:46:47 -0600 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.14) Gecko/20080421 Thunderbird/2.0.0.14 Mnenhy/0.7.5.666 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
According to Alfred M. Szmidt on 7/21/2008 9:30 PM:
| Why can not just a simple _warning_ message be displayed at the end of
| the run instead? That does not punish anyone, and users are informed
| that they installed something that has stale cruft in it, and they can
| easilly do `make uninstall', `make all' or whatever to fix it; or
| simply ignore it.
OK, I'm toning down the response:
- --
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkiFWCcACgkQ84KuGfSFAYABKwCeLY4V5hGfDPo/q1/ANfEhgqmd
pKkAoMsYVAj83pRw3KPPtSUZPPsFvq/m
=pD0I
-----END PGP SIGNATURE-----
>From 662cd06405c078f7b9a2ab1cbab9f36131269979 Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Mon, 21 Jul 2008 21:45:30 -0600
Subject: [PATCH] Warn, not fail, on stale version.
* top/GNUmakefile (_curr-ver): Tone down previous patch.
Signed-off-by: Eric Blake <address@hidden>
---
ChangeLog | 3 +++
top/GNUmakefile | 6 +++---
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index ef2f20a..f741b9f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
2008-07-21 Eric Blake <address@hidden>
+ Warn, not fail, on stale version.
+ * top/GNUmakefile (_curr-ver): Tone down previous patch.
+
Don't allow installation with stale devel version number.
* top/GNUmakefile (_is-install-target): New macro.
(_curr-ver): Forbid installation with stale version number.
diff --git a/top/GNUmakefile b/top/GNUmakefile
index 0f1bba9..ea5e72c 100644
--- a/top/GNUmakefile
+++ b/top/GNUmakefile
@@ -67,10 +67,10 @@ ifeq ($(_have-git-version-gen)0,yes$(MAKELEVEL))
# recompilation after 'make all'. But as long as changing the version
# string alters config.h, the cost of having 'make all' always have an
# up-to-date version is prohibitive. So, as a compromise, we merely
- # refuse to install if the version string is out of date; the user
- # must run 'autoreconf' (or something like 'make distcheck') to
+ # warn when installing a version string that is out of date; the user
+ # should run 'autoreconf' (or something like 'make distcheck') to
# fix the version, 'make all' to propagate it, then 'make install'.
- $(error version string $(VERSION) is out of date; run autoreconf
before installing)
+ $(info WARNING: version string $(VERSION) is out of date; run
autoreconf -f to fix it)
else
$(info INFO: running autoreconf for new version string: $(_curr-ver))
_dummy := $(shell cd $(srcdir) && rm -rf autom4te.cache .version \
--
1.5.6.3
- Re: GNUmakefile and 'make install', (continued)
- Re: GNUmakefile and 'make install', Eric Blake, 2008/07/18
- Re: GNUmakefile and 'make install', Paul Eggert, 2008/07/18
- Re: GNUmakefile and 'make install', Alfred M. Szmidt, 2008/07/18
- Re: GNUmakefile and 'make install', Jim Meyering, 2008/07/18
- Re: GNUmakefile and 'make install', Ralf Wildenhues, 2008/07/18
- Re: GNUmakefile and 'make install', Eric Blake, 2008/07/21
- Re: GNUmakefile and 'make install', Jim Meyering, 2008/07/21
- Re: GNUmakefile and 'make install', Bruno Haible, 2008/07/21
- Re: GNUmakefile and 'make install', Eric Blake, 2008/07/21
- Re: GNUmakefile and 'make install', Alfred M. Szmidt, 2008/07/21
- Re: GNUmakefile and 'make install',
Eric Blake <=
- Re: GNUmakefile and 'make install', Alfred M. Szmidt, 2008/07/22
- Re: git-version-gen and 'make install', Bruno Haible, 2008/07/21