[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: glob win32 compatibility fixes

From: Bruno Haible
Subject: Re: [PATCH]: glob win32 compatibility fixes
Date: Fri, 12 Sep 2008 02:17:32 +0200
User-agent: KMail/1.5.4

Hi Yoann,

> Attached are a few patch that fixes glob ...
> compilation problem under MinGW.

A couple of details in this patch can be improved:

  - The predefine 'WIN32' is sometimes also defined for Cygwin, and is
    not defined on some native Win32 platforms. The right test for platforms
    that use the MSVCRT is
       (defined _WIN32 || defined __WIN32__) && ! defined __CYGWIN__

  - You comment out the use of <pwd.h> and provide no replacement.
    Nowadays, Windows systems have a home directory per user, but
    getenv("HOME") is usually not set. The standard way to get the
    home directory is getenv("HOMEDRIVE") and getenv("HOMEPATH") and
    glue the two strings together (by simple string concatenation).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]