[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: poll module issue on Win32

From: Paolo Bonzini
Subject: Re: [PATCH]: poll module issue on Win32
Date: Fri, 12 Sep 2008 11:06:15 +0200
User-agent: Thunderbird (Macintosh/20080707)

>>> I tried updating the poll module with your patch, but it's not
>>> compiling:
>> Thanks.
> Thanks for the update, tried it, it compile, but poll() will immediatly
> fail with "Invalid argument" on non connected socket. 

Have you included the other patch too?  The updated poll expects file
descriptors, not socket descriptors (and the other patch ensures that it
gets the right kind).

> I didn't tried tracing the problem yet, but if you could provide a
> complete unit-test along with the module, it would make the testing on
> different platform much easier!

You're right, there are no tests, because it's hard to write this kind
of unit test in a portable way.  Still (and unfortunately) that would
probably help for small incremental changes, but for a rewrite it is
possible that something very basic is screwed up.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]