bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] testsuite for poll(2)


From: Eric Blake
Subject: Re: [PATCH] testsuite for poll(2)
Date: Fri, 12 Sep 2008 07:23:22 -0600
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080708 Thunderbird/2.0.0.16 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Paolo Bonzini on 9/12/2008 7:11 AM:
> It is minimal in that it only tests one descriptor at a time.  But it
> has several tests for both sockets and pipes (and if compiled with
> -DINTERACTIVE, TTYs too), so while it does not cover a lot of code in
> the poll emulation it does cover all the subtleties.

> +enum { FALSE, TRUE };

Why not use <stdbool.h> and false/true rather than adding FALSE/TRUE?

At any rate, I've copied your poll work to a safer branch:
http://repo.or.cz/w/gnulib/ericb.git?a=shortlog;h=refs/heads/poll

(the drawback of a mob branch is that you can't be sure how long your push
will survive before the next guy uses it)

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjKbUoACgkQ84KuGfSFAYAmYgCfSgqJgqOWS4+6V/P8fyaQLZPV
YTMAn2VSTDOWCze10VTs3/ZooGNS4HH6
=DpBS
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]