[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] avoid spurious test failure when library is built without AC
Re: [PATCH] avoid spurious test failure when library is built without ACL support
Tue, 16 Sep 2008 00:35:01 +0200
> Bruno, I think you wrote the test, so I'll wait to hear from you
> before pushing.
> * m4/acl.m4 (USE_ACL): Define as a shell variable, too, for...
> * modules/acl-tests (Makefile.am) [TESTS_ENVIRONMENT]: Add USE_ACL.
> * tests/test-file-has-acl.sh: Skip if USE_ACL == 0.
> * tests/test-copy-acl.sh: Likewise.
All fine with me. Perfect.
> When compiling without sys/acl.h or any of various other conditions
> that inhibit use of ACL support, these two tests would fail: ...
> That's because the acl code would be compiled with
> #define USE_ACL 0
That's easy to handle if the ACL support is recognized to be insufficient
at configure time. If the condition becomes apparent only at run time, or
on particular file systems, some changes to the code or unit tests may be