[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: Do not allow countable dayshifts in getdate.y

From: Jim Meyering
Subject: Re: [PATCH]: Do not allow countable dayshifts in getdate.y
Date: Mon, 29 Sep 2008 23:25:26 +0200

Ondřej Vašík <address@hidden> wrote:
> this patch for getdate.y module restricts usage of countable dayshifts
> e.g. +40 tommorow ago, next yesterday etc.
> Tests to gnulib getdate testsuite were added.
> As this usage of dayshifts is quite insane, I guess no documentation for
> it is required.

This looks fine.  I've pushed it.
The only changes I made were to the log message.
i.e., leave a blank line after the summary, change tense/wording, etc.

>From d0029700e7d24d9bb93608e77eb1341948e421fe Mon Sep 17 00:00:00 2001
From: =?utf-8?q?Ond=C5=99ej=20Va=C5=A1=C3=ADk?= <address@hidden>
Date: Fri, 26 Sep 2008 15:28:49 +0200
Subject: [PATCH] getdate.y: disallow countable dayshifts like "4 yesterday ago"

* lib/getdate.y (relative_time_table) [tDAY_SHIFT]: New type for
exactly specified dayshifts.
(dayshift): New rule.
(rel): Add dayshift.
(relative_time_table) [tomorrow, yesterday, today, now]:
Use tDAY_SHIFT in place of tDAY_UNIT.
* tests/test-getdate.c: Add tests for now-disallowed countable
dayshifts, e.g., "4 yesterday ago".

reply via email to

[Prev in Thread] Current Thread [Next in Thread]