Re: [PATCH] Implementation of fsync for Windows

[Bruno Haible]

Richard W.M. Jones wrote:
> This patch implements fsync for Windows.

Nice and quite well done. Bravo for having understood the many idioms used
in gnulib.

Just two minor comments:

  - The phrase "cross-compilers like MinGW" is misleading.
    MinGW is is often used natively, not cross-compiled. There are three
    ways to use MinGW natively:
      - using MSYS as development environment,
      - using Cygwin as development environment, with the right CPPFLAGS
        and LDFLAGS,
      - on Linux, with a kernel configuration that will make .exe files
        run through 'wine', and with gcc configured as a cross-compiler.
    Also mingw is more than a compiler: it's a set of libraries, include files
    and compiler.

  - The code can be a little streamlined by removing the 'err' variable:

      switch (GetLastError ())
      ...

Bruno