[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] implement full-blown select(2) for winsock

From: Bruno Haible
Subject: Re: [PATCH] implement full-blown select(2) for winsock
Date: Sun, 5 Oct 2008 17:30:43 +0200
User-agent: KMail/1.5.4

Paolo Bonzini wrote:
> > Here is a proposal that should acknowledge both of your arguments:
> > Provide separate modules 'select' separate from 'sys_select', like we do
> > in the rest of gnulib, but if 'sys_select' is used without 'select', then
> >   #define select select_used_without_requesting_gnulib_module_select
> > so that the developer gets an explicit error message, rather than falling
> > into a pitfall.
> A mandatory link warning (i.e. always enabled, not just with posixcheck)
> would also work for me.

The link warnings work only on ELF platforms that use GNU ld (see
build-aux/link-warning.h). That's not the case with mingw: the binary file
format is COFF, not ELF. So the link error is the only way to avoid the
pitfall for the developer.

With Simon's agreement, I've applied the sys_select patch, and split the
tests module as well:

        * modules/select-tests: New file, mostly copied from
        * tests/test-select.c: New file, mostly copied from
        * tests/test-sys_select.c: Move most of the code to tests/test-select.c.
        * modules/sys_select-tests (Depends-on): Remove all dependencies.
        (Makefile.am): Remove test_sys_select_LDADD.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]