[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: test-poll vs ioctl

From: Paolo Bonzini
Subject: Re: test-poll vs ioctl
Date: Mon, 20 Oct 2008 22:31:49 -0400
User-agent: Thunderbird (Macintosh/20080914)

>   a) Rename winsock.c to w32sock.h.
>      Create a file connect.c containing
>        #define GNULIB_CONNECT 1
>        #include "w32sock.h"
>      and similarly for the other modules that make up winsock.c.
>      Remove the gl_MODULE_INDICATOR([$1]) line from the definition of
>   b) Split winsock.c into accept.c, connect.c, etc. - like we are doing
>      in gnulib for most other functionalities. The inline functions
>      (FD_TO_SOCKET, SOCKET_TO_FD, set_winsock_errno) can go to a private
>      header file, let's say, w32sock.h or socket-internal.h.
> I would prefer b), because it's leads to a more understandable code structure.

I have no particular preference.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]