Alan Hourihane: [bug #24687] implicit usage of mbsinit & mbrtowc

[Sergey Poznyakoff]

Hello,

A user of Texinfo reported this:

> URL:
>   <http://savannah.gnu.org/bugs/?24687>
> 
>                  Summary: implicit usage of mbsinit & mbrtowc
>                  Project: texinfo - GNU documentation system
[...]
> Details:
> 
> In texinfo 4.13 the files gnulib/lib/mbuiter.h and gnulib/lib/mbiter.h have
> implicit usage of the functions mbsinit() and mbrtowc() without checking the
> HAVE_MBSINIT & HAVE_MBRTOWC defines.
> 
> This renders compilation of 4.13 inoperable on these systems, and you get the
> build errors below....
> 
> display.o:display.o:(.text+0x786): undefined reference to `mbrtowc'
> display.o:display.o:(.text+0x78c): undefined reference to `mbsinit'

Indeed, the only place in gnulib where these functions are used
conditionally is in lib/quotearg.c. Should not we apply this approach
to other sources as well?

Regards,
Sergey