[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?
From: |
James Youngman |
Subject: |
Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ? |
Date: |
Sun, 30 Nov 2008 23:21:04 +0000 |
On Sat, Nov 29, 2008 at 3:53 PM, James Youngman <address@hidden> wrote:
> On Sat, Nov 29, 2008 at 3:46 PM, Jim Meyering <address@hidden> wrote:
>> Jim Meyering <address@hidden> wrote:
>>> "James Youngman" <address@hidden> wrote:
>>>> As far as I can see, the variable type is assigned in the function
>>>> above, but never used. Did you mean to use "type" rather than
>>>> "dtype" in the expression which assigns to st->st_mode?
>>>
>>> Thanks again.
>>> Here's the patch I'll push as soon as you say ok:
>>
>> I hadn't tested enough after all.
>> That didn't work either. But this does.
>> With *it*, all 1133 of find's tests really do pass:
>
> Looks good to me, though I did no local testing.
>
> I will apply your find patch at some point this weekend, I hope.
I've applied the patch to the CVS trunk for findutils; it will appear
in findutils 4.5.3, whenever that is released.
Thanks!
James.
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Eric Blake, 2008/11/27
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, James Youngman, 2008/11/28
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/28
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, James Youngman, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, James Youngman, 2008/11/29
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?,
James Youngman <=
- Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Jim Meyering, 2008/11/29
Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?, Christian Franke, 2008/11/28