Re: [PATCH] Exclude optimization

[Ralf Wildenhues]

Hello Sergey,

* Sergey Poznyakoff meant to write on Tue, Aug 11, 2009 at 09:37:40PM CEST:
> > This would seem to still mis-characterizes patterns such as 'foo]'.
> 
> Yes, of course. But this function is by no means thought to correctly
> catch all possible variations of wildcard patterns (one would have to
> duplicate fnmatch for that). Its purpose is to give a rough estimate
> on whether a given pattern is a fixed literal or a wildcard string.
> It may, in some cases, incorrectly recognize the former to be the
> latter, but never vice-versa.

Sure.  But if there is a chance to improve the estimate by a trivial
change, without any downsides, why not go for it?

Anyway, I agree that this is a very minor detail, probably not worth the
electrons I'm writing this with, and I'm not going to argue further.

Cheers,
Ralf