Re: SIZEOF macro

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 12/24/2009 4:21 PM:
> According to Bruno Haible on 12/24/2009 1:08 PM:
>>>> Either way we create macros.h and put ASSERT there
>> Done this this big commit, now.
>
> Hmm.  macros.h defines SIZEOF, and test-argv-iter.c defines
> ARRAY_CARDINALITY, both of which are used to determine the size of an
> array.  I kind of prefer the name in test-argv-iter (to me, sizeof implies
> a size_t count of bytes, not the number of elements).  Is it okay to
> rename the macro in macros.h to ARRAY_CARDINALITY, adjust all callers, and
> to simplify test-argv-iter?

Like this?  It's also pretty quick to go with a shorter name of CARDINALITY:

for f in `git grep -l ARRAY_CARDINALITY tests`; do \
  sed -i 's/ARRAY_CARDINALITY/CARDINALITY/' $f
done

2009-12-24  Eric Blake  <address@hidden>

        tests: rename SIZEOF to ARRAY_CARDINALITY
        * tests/macros.h (SIZEOF): Rename...
        (ARRAY_CARDINALITY): ...to this.
        * tests/test-argv-iter.c (ARRAY_CARDINALITY): Delete.
        * tests/test-hash.c (ARRAY_CARDINALITY): Likewise.
        * tests/test-array_list.c: Prefer ARRAY_CARDINALITY over SIZEOF.
        * tests/test-array_oset.c: Likewise.
        * tests/test-avltree_list.c: Likewise.
        * tests/test-avltree_oset.c: Likewise.
        * tests/test-avltreehash_list.c: Likewise.
        * tests/test-carray_list.c: Likewise.
        * tests/test-linked_list.c: Likewise.
        * tests/test-linkedhash_list.c: Likewise.
        * tests/test-localename.c: Likewise.
        * tests/test-mbmemcasecmp.h: Likewise.
        * tests/test-rbtree_list.c: Likewise.
        * tests/test-rbtree_oset.c: Likewise.
        * tests/test-rbtreehash_list.c: Likewise.
        * tests/test-snprintf-posix.h: Likewise.
        * tests/test-sprintf-posix.h: Likewise.
        * tests/test-striconveh.c: Likewise.
        * tests/test-striconveha.c: Likewise.
        * tests/test-vasnprintf-posix.c: Likewise.
        * tests/test-vasprintf-posix.c: Likewise.
        * tests/unicase/test-casecmp.h: Likewise.
        * tests/unicase/test-is-cased.h: Likewise.
        * tests/unicase/test-is-casefolded.h: Likewise.
        * tests/unicase/test-is-lowercase.h: Likewise.
        * tests/unicase/test-is-titlecase.h: Likewise.
        * tests/unicase/test-is-uppercase.h: Likewise.
        * tests/unicase/test-mapping-part2.h: Likewise.
        * tests/unicase/test-predicate-part2.h: Likewise.
        * tests/unicase/test-u16-casecmp.c: Likewise.
        * tests/unicase/test-u16-casefold.c: Likewise.
        * tests/unicase/test-u16-is-casefolded.c: Likewise.
        * tests/unicase/test-u16-is-lowercase.c: Likewise.
        * tests/unicase/test-u16-is-uppercase.c: Likewise.
        * tests/unicase/test-u16-tolower.c: Likewise.
        * tests/unicase/test-u16-totitle.c: Likewise.
        * tests/unicase/test-u16-toupper.c: Likewise.
        * tests/unicase/test-u32-casecmp.c: Likewise.
        * tests/unicase/test-u32-casefold.c: Likewise.
        * tests/unicase/test-u32-is-casefolded.c: Likewise.
        * tests/unicase/test-u32-is-lowercase.c: Likewise.
        * tests/unicase/test-u32-is-uppercase.c: Likewise.
        * tests/unicase/test-u32-tolower.c: Likewise.
        * tests/unicase/test-u32-totitle.c: Likewise.
        * tests/unicase/test-u32-toupper.c: Likewise.
        * tests/unicase/test-u8-casecmp.c: Likewise.
        * tests/unicase/test-u8-casefold.c: Likewise.
        * tests/unicase/test-u8-is-casefolded.c: Likewise.
        * tests/unicase/test-u8-is-lowercase.c: Likewise.
        * tests/unicase/test-u8-is-uppercase.c: Likewise.
        * tests/unicase/test-u8-tolower.c: Likewise.
        * tests/unicase/test-u8-totitle.c: Likewise.
        * tests/unicase/test-u8-toupper.c: Likewise.
        * tests/unicase/test-ulc-casecmp.c: Likewise.
        * tests/uniconv/test-u16-conv-from-enc.c: Likewise.
        * tests/uniconv/test-u16-conv-to-enc.c: Likewise.
        * tests/uniconv/test-u16-strconv-from-enc.c: Likewise.
        * tests/uniconv/test-u16-strconv-to-enc.c: Likewise.
        * tests/uniconv/test-u32-conv-from-enc.c: Likewise.
        * tests/uniconv/test-u32-conv-to-enc.c: Likewise.
        * tests/uniconv/test-u32-strconv-from-enc.c: Likewise.
        * tests/uniconv/test-u32-strconv-to-enc.c: Likewise.
        * tests/uniconv/test-u8-conv-from-enc.c: Likewise.
        * tests/uniconv/test-u8-conv-to-enc.c: Likewise.
        * tests/uniconv/test-u8-strconv-from-enc.c: Likewise.
        * tests/uniconv/test-u8-strconv-to-enc.c: Likewise.
        * tests/unictype/test-decdigit.c: Likewise.
        * tests/unictype/test-digit.c: Likewise.
        * tests/unictype/test-numeric.c: Likewise.
        * tests/unictype/test-predicate-part2.h: Likewise.
        * tests/unilbrk/test-u16-possible-linebreaks.c: Likewise.
        * tests/unilbrk/test-u16-width-linebreaks.c: Likewise.
        * tests/unilbrk/test-u32-possible-linebreaks.c: Likewise.
        * tests/unilbrk/test-u32-width-linebreaks.c: Likewise.
        * tests/unilbrk/test-u8-possible-linebreaks.c: Likewise.
        * tests/unilbrk/test-u8-width-linebreaks.c: Likewise.
        * tests/unilbrk/test-ulc-possible-linebreaks.c: Likewise.
        * tests/unilbrk/test-ulc-width-linebreaks.c: Likewise.
        * tests/uninorm/test-u16-nfc.c: Likewise.
        * tests/uninorm/test-u16-nfd.c: Likewise.
        * tests/uninorm/test-u16-nfkc.c: Likewise.
        * tests/uninorm/test-u16-nfkd.c: Likewise.
        * tests/uninorm/test-u16-normcmp.c: Likewise.
        * tests/uninorm/test-u16-normcmp.h: Likewise.
        * tests/uninorm/test-u32-nfc.c: Likewise.
        * tests/uninorm/test-u32-nfd.c: Likewise.
        * tests/uninorm/test-u32-nfkc.c: Likewise.
        * tests/uninorm/test-u32-nfkd.c: Likewise.
        * tests/uninorm/test-u32-normcmp.c: Likewise.
        * tests/uninorm/test-u32-normcmp.h: Likewise.
        * tests/uninorm/test-u8-nfc.c: Likewise.
        * tests/uninorm/test-u8-nfd.c: Likewise.
        * tests/uninorm/test-u8-nfkc.c: Likewise.
        * tests/uninorm/test-u8-nfkd.c: Likewise.
        * tests/uninorm/test-u8-normcmp.c: Likewise.
        * tests/uninorm/test-u8-normcmp.h: Likewise.
        * tests/uninorm/test-uninorm-filter-nfc.c: Likewise.
        * tests/uniwbrk/test-u16-wordbreaks.c: Likewise.
        * tests/uniwbrk/test-u32-wordbreaks.c: Likewise.
        * tests/uniwbrk/test-u8-wordbreaks.c: Likewise.
        * tests/uniwbrk/test-ulc-wordbreaks.c: Likewise.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksz+uIACgkQ84KuGfSFAYBC7gCfVdI7VWGv5U/MY3hlb/CMi0ZG
yqcAn2m5KS6ViUuSASbZ2EEFWXJ7GDbm
=nkxv
-----END PGP SIGNATURE-----

gnulib.patch318.gz
Description: GNU Zip compressed data