Re: [PATCH] isdir: clean up, since at least grep still uses it

[Jim Meyering]

Jim Meyering wrote:
> FYI, grep is using isdir, and merely compiling it with
> gcc's -Wmissing-prototypes would provoke this:
>
>     isdir.c:28: error: no previous prototype for 'isdir'
>
> so I've cleaned up:
>
>
>>From 8fedd05841d5e693cd8fb5266a7963bc075c45f6 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Sat, 26 Dec 2009 09:56:23 +0100
> Subject: [PATCH] isdir: clean up, since at least grep still uses it
>
> * lib/isdir.c: Include "isdir.h".
> (S_ISDIR): Remove now-unneeded definition.
> * modules/isdir (Files): Add lib/isdir.h.
> * lib/isdir.h: New file, with declaration.
> * m4/isdir.m4: Remove file -- unneeded.

One more piece was required:

>From 39e4e23268d4b613c46248b425be79aa1c0b0509 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 26 Dec 2009 11:01:59 +0100
Subject: [PATCH] isdir: complete the removal of m4/isdir.m4

* modules/isdir (configure.ac): Remove reference to gl_ISDIR.
---
 ChangeLog     |    3 +++
 modules/isdir |    1 -
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 088bb3b..edcfb13 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2009-12-26  Jim Meyering  <address@hidden>

+       isdir: complete the removal of m4/isdir.m4
+       * modules/isdir (configure.ac): Remove reference to gl_ISDIR.
+
        isdir: clean up, since at least grep still uses it
        * lib/isdir.c: Include "isdir.h".
        (S_ISDIR): Remove now-unneeded definition.
diff --git a/modules/isdir b/modules/isdir
index 83193e1..aab5f84 100644
--- a/modules/isdir
+++ b/modules/isdir
@@ -9,7 +9,6 @@ Depends-on:
 stat

 configure.ac:
-gl_ISDIR

 Makefile.am:
 lib_SOURCES += isdir.c
--
1.6.6.287.gff4d1