[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: link-warning usage improvements
From: |
Bruno Haible |
Subject: |
Re: link-warning usage improvements |
Date: |
Thu, 31 Dec 2009 22:01:39 +0100 |
User-agent: |
KMail/1.9.9 |
Eric Blake wrote:
> * lib/spawn.in.h (posix_spawn, posix_spawnp, posix_spawnattr_init)
> (posix_spawnattr_destroy, posix_spawnattr_getsigdefault)
> (posix_spawnattr_setsigdefault, posix_spawnattr_getsigmask)
> (posix_spawnattr_setsigmask, posix_spawnattr_getflags)
> (posix_spawnattr_setflags, posix_spawnattr_getpgroup)
> (posix_spawnattr_setpgroup, posix_spawnattr_getschedpolicy)
> (posix_spawnattr_setschedpolicy, posix_spawnattr_getschedparam)
> (posix_spawnattr_setschedparam, posix_spawn_file_actions_init)
> (posix_spawn_file_actions_destroy)
> (posix_spawn_file_actions_addopen)
> (posix_spawn_file_actions_addclose)
> (posix_spawwn_file_actions_adddup2): Likewise.
Looks like some part of this patch was misapplied: posix_spawnattr_getsigdefault
gets a link warning twice, and some others under the wrong #elif. I'm applying
this fix:
2009-12-31 Bruno Haible <address@hidden>
spawn: Fix misapplied patch.
* lib/spawn.in.h (posix_spawnattr_getflags, posix_spawnattr_setflags,
posix_spawnattr_getpgroup, posix_spawnattr_setpgroup): Correct the link
warnings for GNULIB_POSIXCHECK.
*** lib/spawn.in.h.orig Thu Dec 31 21:55:04 2009
--- lib/spawn.in.h Thu Dec 31 21:54:31 2009
***************
*** 306,315 ****
__THROW _GL_ARG_NONNULL ((1, 2));
# endif
#elif defined GNULIB_POSIXCHECK
! # undef posix_spawnattr_getsigdefault
! # define posix_spawnattr_getsigdefault(a, b) \
! (GL_LINK_WARNING ("posix_spawnattr_getsigdefault is unportable - " \
! "use gnulib module posix_spawnattr_getsigdefault for
portability"), \
posix_spawnattr_getsigdefault (a, b))
#endif
--- 306,315 ----
__THROW _GL_ARG_NONNULL ((1, 2));
# endif
#elif defined GNULIB_POSIXCHECK
! # undef posix_spawnattr_getflags
! # define posix_spawnattr_getflags(a, b) \
! (GL_LINK_WARNING ("posix_spawnattr_getflags is unportable - " \
! "use gnulib module posix_spawnattr_getflags for
portability"), \
posix_spawnattr_getsigdefault (a, b))
#endif
***************
*** 324,333 ****
__THROW _GL_ARG_NONNULL ((1));
# endif
#elif defined GNULIB_POSIXCHECK
! # undef posix_spawnattr_getflags
! # define posix_spawnattr_getflags(a, b) \
! (GL_LINK_WARNING ("posix_spawnattr_getflags is unportable - " \
! "use gnulib module posix_spawnattr_getflags for
portability"), \
posix_spawnattr_getflags (a, b))
#endif
--- 324,333 ----
__THROW _GL_ARG_NONNULL ((1));
# endif
#elif defined GNULIB_POSIXCHECK
! # undef posix_spawnattr_setflags
! # define posix_spawnattr_setflags(a, b) \
! (GL_LINK_WARNING ("posix_spawnattr_setflags is unportable - " \
! "use gnulib module posix_spawnattr_setflags for
portability"), \
posix_spawnattr_getflags (a, b))
#endif
***************
*** 342,351 ****
__THROW _GL_ARG_NONNULL ((1, 2));
# endif
#elif defined GNULIB_POSIXCHECK
! # undef posix_spawnattr_setflags
! # define posix_spawnattr_setflags(a, b) \
! (GL_LINK_WARNING ("posix_spawnattr_setflags is unportable - " \
! "use gnulib module posix_spawnattr_setflags for
portability"), \
posix_spawnattr_setflags (a, b))
#endif
--- 342,351 ----
__THROW _GL_ARG_NONNULL ((1, 2));
# endif
#elif defined GNULIB_POSIXCHECK
! # undef posix_spawnattr_getpgroup
! # define posix_spawnattr_getpgroup(a, b) \
! (GL_LINK_WARNING ("posix_spawnattr_getpgroup is unportable - " \
! "use gnulib module posix_spawnattr_getpgroup for
portability"), \
posix_spawnattr_setflags (a, b))
#endif
***************
*** 359,364 ****
--- 359,370 ----
pid_t __pgroup)
__THROW _GL_ARG_NONNULL ((1));
# endif
+ #elif defined GNULIB_POSIXCHECK
+ # undef posix_spawnattr_setpgroup
+ # define posix_spawnattr_setpgroup(a, b) \
+ (GL_LINK_WARNING ("posix_spawnattr_setpgroup is unportable - " \
+ "use gnulib module posix_spawnattr_setpgroup for
portability"), \
+ posix_spawnattr_setflags (a, b))
#endif
#if @GNULIB_POSIX_SPAWNATTR_GETSCHEDPOLICY@
- link-warning usage improvements, Eric Blake, 2009/12/24
- Re: link-warning usage improvements, Bruno Haible, 2009/12/31
- Re: link-warning usage improvements, Bruno Haible, 2009/12/31
- Re: link-warning usage improvements, Eric Blake, 2009/12/31
- Re: link-warning usage improvements, Eric Blake, 2009/12/31
- Re: link-warning usage improvements, Bruno Haible, 2009/12/31
- Re: link-warning usage improvements, Eric Blake, 2009/12/31