[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnulib bootstrap and git submodules
From: |
Jim Meyering |
Subject: |
Re: gnulib bootstrap and git submodules |
Date: |
Wed, 24 Feb 2010 18:06:20 +0100 |
Eric Blake wrote:
> According to Jim Meyering on 2/17/2010 10:21 AM:
>>> or should we just assume that git 1.6.4 or newer is widespread enough to
>>> not be worth the hassle?
>>
>> I'd prefer to assume git 1.6.4 to keep things simpler, at least until
>> someone comes up with a compelling reason to add code to support older git.
>
> Libvirt came up with the compelling reason - Fedora Core 11 only has
> 1.6.2.5, and RPEL 5 is back at git 1.5.5. This should fix it, by
> borrowing ideas from m4's bootstrap script.
>
> --
> Eric Blake address@hidden +1-801-349-2682
> Libvirt virtualization library http://libvirt.org
>
> From 980a90b55fd2721864880aed353bd05ba5b69365 Mon Sep 17 00:00:00 2001
> From: Eric Blake <address@hidden>
> Date: Wed, 24 Feb 2010 09:48:16 -0700
> Subject: [PATCH] bootstrap: allow older git
>
> git 1.6.4 is too new to be universally available yet.
>
> * build-aux/bootstrap (GNULIB_SRCDIR): Add fallback if git is
> older than 1.6.4. Requested by the libvirt project.
Thanks.
That looks right to me.
...
> + "`git_modules_config submodule.gnulib.url`" "$gnulib_path" \
Please use $(...) rather than `...`.
That is fine, since bootstrap already has other uses of $(...).