[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype
From: |
Bruno Haible |
Subject: |
Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype |
Date: |
Fri, 19 Mar 2010 02:40:53 +0100 |
User-agent: |
KMail/1.9.9 |
Hi Eric,
Rapid review:
> diff --git a/m4/forkpty.m4 b/m4/forkpty.m4
> index 38b51b7..f1da918 100644
> --- a/m4/forkpty.m4
> +++ b/m4/forkpty.m4
> @@ -23,9 +23,83 @@ AC_DEFUN([gl_PTY_LIB],
> AC_DEFUN([gl_FORKPTY],
> [
> AC_REQUIRE([gl_PTY_LIB])
> + AC_REQUIRE([gl_PTY])
> +
> + AC_CHECK_DECLS([forkpty],,, [[
> +#if HAVE_UTIL_H
> +# include <util.h>
> +#endif
> +#if HAVE_LIBUTIL_H
> +# include <libutil.h>
> +#endif
> +]])
Why does this set of includes not contain
#if HAVE_PTY_H
# include <pty.h>
#endif
? Isn't it needed on glibc systems?
> AC_DEFUN([gl_OPENPTY],
> [
> AC_REQUIRE([gl_PTY_LIB])
> + AC_REQUIRE([gl_PTY])
> +
> + AC_CHECK_DECLS([openpty],,, [[
> +#if HAVE_UTIL_H
> +# include <util.h>
> +#endif
> +#if HAVE_LIBUTIL_H
> +# include <libutil.h>
> +#endif
> +]])
Likewise.
Bruno
- [PATCH 2/3] forkpty, openpty: split functions into new modules, (continued)
- [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Simon Josefsson, 2010/03/19
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/19
- Re: [PATCH 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/19
- [PATCH 1/3] pty: improve replacement header, Eric Blake, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/18
- Re: [PATCH 1/3] pty: improve replacement header, Bruno Haible, 2010/03/19
- [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18
- Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype,
Bruno Haible <=
- Re: [PATCH 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18
- [PATCHv2 1/3] pty: improve replacement header, Eric Blake, 2010/03/18
- [PATCHv2 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/18
- Re: [PATCHv2 2/3] forkpty, openpty: split functions into new modules, Bruno Haible, 2010/03/21
- Re: [PATCHv2 2/3] forkpty, openpty: split functions into new modules, Eric Blake, 2010/03/22
- [PATCHv2 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Eric Blake, 2010/03/18
- Re: [PATCHv2 3/3] forkpty, openpty: prefer glibc's const-safe prototype, Bruno Haible, 2010/03/19