Re: [PATCH 3/3] Macro _prohibit_regexp replaced by _sc_search_regep and rules adapted to use the new macro.

[Eric Blake]

On 03/31/2010 01:23 PM, Jose E. Marchesi wrote:
> Regarding the unaligned backslashes:
>     
>     Subject: [PATCH 4/8] avoid long lines; align backslashes
>     [...]
>     +     || { msg='halt not defined' $(_sc_say_and_exit) };                  
> \
>     +                                                                 \
> 
> I am pretty sure that it is git-commit who is screwing up the
> alignment.  In my working copy the alignment looks ok, but they show
> unaligned in the output of both git-format-patch and git-diff.

It may also be a factor of tabs vs. spaces.  Since3 you used tabs, but
the diff indents your line by one space, then lines that had a
single-width leading tab after the last non-whitespace all the sudden
appear off by 7, compared to all leading multi-width tabs which merely
get represented with one less tab.  So what looks aligned in the editor
ends up looking weird in the diff.  Always using spaces resolves the
problems (everything is uniformly shifted right by one column).

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature