[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnumakefile: don't squelch _version output
From: |
Eric Blake |
Subject: |
Re: [PATCH] gnumakefile: don't squelch _version output |
Date: |
Wed, 31 Mar 2010 16:28:05 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b1 Thunderbird/3.0.3 |
On 03/30/2010 05:40 PM, Eric Blake wrote:
> Borrowing from a trick I discovered on the libvirt list.
>
> * top/GNUmakefile (GNUmakefile): Create one-shot dependency rather
> than using $(shell) to run _version target.
> (_autoreconf): Run verbosely, by default.
>
> Signed-off-by: Eric Blake <address@hidden>
> ---
>
> This was quite tricky to implement. I've tested (with m4) that this
> runs autoreconf at most once, and only when the version string is
> out-of-date. The _version target has to make sure Makefile is
> up-to-date (otherwise, autoreconf is run twice), and at least one
> makefile has to change timestamps (or GNU make won't reload the new
> value of $(VERSION) and will proceed with invalid version strings).
>
> But the end result is that you now see more progress during an
> autoreconf run that is updataing an intra-release version number.
>
> I'll wait for a day or two, or a positive review (whichever comes
> first) before pushing it.
I've gone ahead and pushed this; I've extended my testing to coreutils
as well.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature