bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] stdio-impl.h has too indiscriminate #ifdef


From: Hauke Fath
Subject: Re: [Patch] stdio-impl.h has too indiscriminate #ifdef
Date: Sun, 4 Apr 2010 23:48:43 +0200
User-agent: Eudora Light 3.1.3 (Macintosh)

At 21:57 Uhr +0100 4.4.2010, Bruno Haible wrote:
>Hi,
>
>Hauke Fath wrote:
>> -# if defined __NetBSD__ || defined __OpenBSD__ /* NetBSD, OpenBSD */
>> +# if (defined __NetBSD__ && __NetBSD__ >= 105270000) || defined
>>__OpenBSD__ /* NetBSD, OpenBSD */
>
>The introduction of the '_ext' field happened in NetBSD on 2001-12-07,
>according to
><http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/stdio/ungetc.c>.
>The tags indicate that it is present starting with NetBSD 1.6. What's
>the condition for testing for NetBSD >= 1.6? Where does your magic number
>105270000 come from?

Thanks for asking,a nd sorry I didn't provide background. A good catch, too
-- it should actually be

if (defined __NetBSD__ && __NetBSD_Version__ >= 105270000)

where __NetBSD_Version__ is defined in <sys/param.h>, in the kernel source
tree at src/sys/sys/param.h.

The relevant version bump of this file is
<http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/param.h?rev=1.135&content-type=
text/x-cvsweb-markup> - see the comment at the top of the page; you can
find an explanation of the fields in the version number in that header.

HTH,
        hauke

--
"It's never straight up and down"     (DEVO)






reply via email to

[Prev in Thread] Current Thread [Next in Thread]