[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new syntax-check rule for @acronym?

From: Simon Josefsson
Subject: Re: new syntax-check rule for @acronym?
Date: Thu, 15 Apr 2010 08:58:32 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

Jim Meyering <address@hidden> writes:

> Simon Josefsson wrote:
>> Eric Blake <address@hidden> writes:
> ...
>>  # Don't use Texinfo @acronym{} as it is not a good idea.
>>  sc_texinfo_acronym:
>> -    @grep -nE '@acronym{'                                           \
>> -        $$($(VC_LIST_EXCEPT) | grep -E '\.texi$$') &&               \
>> +    @if $(VC_LIST_EXCEPT) | grep -lE '\.texi$$' >/dev/null; then    \
> Hi Simon,
> I suggest you also check for .txi and .texinfo suffixes,
> which probably means factoring out the regexps above and below.
> Hmm... in fact, you could even make the regexp overridable:
>   texinfo_suffix_re_ =? '\.(texi(nfo)?|txi)$$'

Good idea!  However I can't make this work, any ideas why the following
doesn't work?

# Don't use Texinfo @acronym{} as it is not a good idea.
texinfo_suffix_re_ =? '\.(texi(nfo)?|txi)$$'
        @prohibit='@acronym{'                                           \
        in_vc_files=$(texinfo_suffix_re_)                               \
        halt='found use of Texinfo @acronym{}'                          \

Results in:

/bin/sh: \.(texi(nfo)?|txi)$: command not found
maint.mk: Should specify either prohibit or require
make: *** [sc_texinfo_acronym] Error 1

There are other places where maint.mk uses a variable with a string
in_vc_files so I'm not sure what the problem is.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]