bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: valgrind-tests.m4


From: Simon Josefsson
Subject: Re: valgrind-tests.m4
Date: Thu, 20 May 2010 08:30:30 +0200
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

Ralf Wildenhues <address@hidden> writes:

> Hi Simon,
>
> I like this patch, with one small nit:
>
> * Simon Josefsson wrote on Wed, May 19, 2010 at 08:41:29AM CEST:
>> +This will run all self-checks under valgrind.  This can be wasteful if
>> +you have many shell scripts or other non-binaries.  Using the Automake
>> +parallel-tests feature, this can be avoided by using the following
>> +instead:
>> +
>> address@hidden
>> +AUTOMAKE_OPTIONS = parallel-tests
>> +TEST_EXTENSIONS = .pl .sh
>> +LOG_COMPILER = $(VALGRIND)
>> address@hidden smallexample
>> +
>> +Then valgrind will only be used for the non-.sh and non-.pl binaries.
>
> I'd write "tests" here instead of "binaries", that would be a tad more
> precise.  (The remaining tests may not all be binaries either.)

I made this change and pushed the patch.

/Simon



reply via email to

[Prev in Thread] Current Thread [Next in Thread]