[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-tar] [PATCH] two patches for --atime-preserve races and other p

From: Paul Eggert
Subject: Re: [Bug-tar] [PATCH] two patches for --atime-preserve races and other problems
Date: Thu, 16 Sep 2010 15:49:22 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100826 Thunderbird/3.0.7

[Adding bug-gnulib.]

On 09/16/10 11:17, Eric Blake wrote:

> Why not just use the gnulib module fdutimensat instead of reimplementing
> this yourself as fd_utimensat?

Mainly because fdutimensat does not let 'tar' pass AT_SYMLINK_NOFOLLOW to the
underlying system call.  Sometimes that flag is needed, sometimes not,
but fdutimensat hardwires a '0'.

If fdutimensat were modified to have an additional "atflag" argument, that
would overcome the main objection.

By the way, in a future version of tar I will also have a need for similar
functions fdchmodat, fdchownat, fdfstatat, but I don't know whether they're
worth gnulibifying.  (It's not entirely clear that fdutimensat is worth
gnulibifying either, to be honest.  :-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]