[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: linkat on Solaris 11
|
From: |
Eric Blake |
|
Subject: |
Re: linkat on Solaris 11 |
|
Date: |
Mon, 27 Dec 2010 11:44:14 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
On 12/27/2010 11:05 AM, Bruno Haible wrote:
> Hi Eric, Jim, Paul,
>
> On Solaris 11 from 2010-11, I get this test failure:
>
> test-linkat.c:194: assertion failed
> /bin/sh: line 10: 4267: Abort(coredump)
> FAIL: test-linkat
>
> The reason is that this expression
> linkat (dfd, BASE "link1", dfd, BASE "sub1/", 0)
> fails with error ENOTDIR, not EEXIST.
>
> Here are two possible fixes: One in the testsuite, one in the linkat()
> replacement (but this one costs CPU cycles at runtime). Which one do you
> prefer?
Relaxing the testsuite to permit ENOTDIR is fine with me (and certainly
cheaper). No need to make linkat() give a specific errno unless we can
prove it helps other code to have that exact failure.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature