Re: [coreutils] [PATCH] coreutils buglets, useless-if-before-free

[Jim Meyering]

Karl Heuer wrote:
> `useless-if-before-free --help' prints a literal
> NUL character instead of the backslash-zero that
> was intended.  Also, the "must lie within the
> first 8 lines" line is on line 9, and hence not
> getting automatically updated.  This patch fixes
> the former by adding a backslash, and the latter
> by condensing the three lines of what-it-does to
> a single line, leaving one line of slack for the
> future.  (An alternative would be to move the
> what-it-does text to appear below the VERSION.)

Thanks, Karl!
FYI, I've pushed that to the gnulib.git repository,
since that's the canonical source for that particular file.
I massaged your summary into a ChangeLog entry and
"git commit"ted it.  Once I'd done that, I ran:

  git format-patch --stdout -1 > FILE

to produce the patch you see below, which includes authorship
information (your name and email) and a commit log message.

We prefer to receive patches of the form below because then
we don't have to write as much and can simply run

  git am FILE

to commit the patch to our local repository.

If you're new to git, here's a quick intro:
  http://git.sv.gnu.org/cgit/coreutils.git/tree/README-hacking

Your patch counts as trivial, so I don't need a gnulib copyright
assignment just yet, but if you think you will be submitting other
changes to gnulib, please fill out the copyright assignment form for
gnulib, and you might as well add coreutils (you can do 4 at once):

  
git.sv.gnu.org/gitweb/?p=gnulib.git;f=doc/Copyright/request-assign.future;hb=HEAD
  http://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html


>From 1b58d734924189cf963936e202f361dd19bd109c Mon Sep 17 00:00:00 2001
From: Karl Heuer <address@hidden>
Date: Sun, 9 Jan 2011 10:16:08 +0100
Subject: [PATCH] useless-if-before-free: fix typo in --help and make the 
internal,

automatic version date update process work once again.
--help output contained a NUL character instead of the
backslash-zero that was intended.  Also, the "must lie within
the first 8 lines" line is on line 9, and hence not getting
automatically updated.
* build-aux/useless-if-before-free: Fix the former by adding a
backslash, and the latter by condensing the three lines of what-it-does
to a single line, leaving one line of slack for the future.
---
 ChangeLog                        |   12 ++++++++++++
 build-aux/useless-if-before-free |    8 +++-----
 2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index eb0d8bd..a2070af 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2011-01-09  Karl Heuer  <address@hidden>
+
+       useless-if-before-free: fix typo in --help and make the internal,
+       automatic version date update process work once again.
+       --help output contained a NUL character instead of the
+       backslash-zero that was intended.  Also, the "must lie within
+       the first 8 lines" line is on line 9, and hence not getting
+       automatically updated.
+       * build-aux/useless-if-before-free: Fix the former by adding a
+       backslash, and the latter by condensing the three lines of what-it-does
+       to a single line, leaving one line of slack for the future.
+
 2011-01-08  Bruno Haible  <address@hidden>

        uninorm tests: Preserve copyright of Unicode data file.
diff --git a/build-aux/useless-if-before-free b/build-aux/useless-if-before-free
index 01a6d3d..a6c228b 100755
--- a/build-aux/useless-if-before-free
+++ b/build-aux/useless-if-before-free
@@ -2,11 +2,9 @@ eval '(exit $?0)' && eval 'exec perl -wST "$0" ${1+"$@"}'
   & eval 'exec perl -wST "$0" $argv:q'
     if 0;
 # Detect instances of "if (p) free (p);".
-# Likewise for "if (p != NULL) free (p);".  And with braces.
-# Also detect "if (NULL != p) free (p);".
-# And with 0 in place of NULL.
+# Likewise "if (p != 0)", "if (0 != p)", or with NULL; and with braces.

-my $VERSION = '2009-04-16 15:57'; # UTC
+my $VERSION = '2011-01-09 01:39'; # UTC
 # The definition above must lie within the first 8 lines in order
 # for the Emacs time-stamp write hook (at end) to update it.
 # If you change this file with Emacs, please let the write hook
@@ -63,7 +61,7 @@ detect free-like functions named FOO and BAR.

 OPTIONS:

-   --list       print only the name of each matching FILE (\0-terminated)
+   --list       print only the name of each matching FILE (\\0-terminated)
    --name=N     add name N to the list of \`free\'-like functions to detect;
                   may be repeated

--
1.7.3.5