[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint.mk: add syntax-check rule: detect unnecessary #include
From: |
Jim Meyering |
Subject: |
Re: [PATCH] maint.mk: add syntax-check rule: detect unnecessary #include <stddef.h> |
Date: |
Mon, 24 Jan 2011 08:00:18 +0100 |
Bruno Haible wrote:
> Jim Meyering wrote:
>> u64.h
>> lib/uninorm/normalize-internal.h
>> xreadlink.h
>>
>> The xreadlink.h use is obviously unused so
>> I've removed it (2nd cset, below),
>> but I haven't looked at the others yet.
>
> I've trimmed it from lib/uninorm/normalize-internal.h as well.
>
> u64.h looks like it could get away without #include <stddef.h> (but I
> haven't tested it).
I've removed it and tested, via
./gnulib-tool --create-testdir --with-tests --test u64
which passed, so I've pushed this.
Then I looked at the maintainer field in modules/u64.
I hope that's ok, Paul.
>From b308995259641fcfe5fb46d291944e14e6edc8e4 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 24 Jan 2011 07:49:01 +0100
Subject: [PATCH] u64: remove unnecessary #include
* lib/u64.h: Don't include <stddef.h>. It was not used.
---
ChangeLog | 5 +++++
lib/u64.h | 1 -
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 4d00591..bea7d1e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-01-24 Jim Meyering <address@hidden>
+
+ u64: remove unnecessary #include
+ * lib/u64.h: Don't include <stddef.h>. It was not used.
+
2011-01-23 Paul Eggert <address@hidden>
Allow the user to avoid the GNULIB_TEST_* macros.
diff --git a/lib/u64.h b/lib/u64.h
index c9412f5..182d649 100644
--- a/lib/u64.h
+++ b/lib/u64.h
@@ -17,7 +17,6 @@
/* Written by Paul Eggert. */
-#include <stddef.h>
#include <stdint.h>
/* Return X rotated left by N bits, where 0 < N < 64. */
--
1.7.3.5.38.gb312b