bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

sc_error_message_uppercase


From: Simon Josefsson
Subject: sc_error_message_uppercase
Date: Thu, 27 Jan 2011 15:43:12 +0100
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.2 (gnu/linux)

I got this from 'make syntax-check' in a project:

oathtool/oathtool.c-225-          printf ("Step size (seconds): %ld\n", 
time_step_size);
oathtool/oathtool.c-235-          printf ("Time now: %s (%ld)\n", outstr, when);
maint.mk: found capitalized error message
make: *** [sc_error_message_uppercase] Fel 1

Is the regexp wrong here?  It looks fine to me, maint.mk:

# Error messages should not start with a capital letter
sc_error_message_uppercase:
        @grep -nEA2 '[^rp]error *\(' $$($(VC_LIST_EXCEPT))              \
            | grep -E '"[A-Z]'                                          \
            | grep -vE '"FATAL|"WARNING|"Java|"C#|PRIuMAX' &&           \
          { echo '$(ME): found capitalized error message' 1>&2;         \
            exit 1; } || :

The project is using the latest gnulib files as of today.

/Simon



reply via email to

[Prev in Thread] Current Thread [Next in Thread]