bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libposix: Add _HEADERS primaries to posix modules.


From: Bruno Haible
Subject: Re: [PATCH] libposix: Add _HEADERS primaries to posix modules.
Date: Mon, 7 Feb 2011 22:22:33 +0100
User-agent: KMail/1.9.9

Hi Jim,

Thanks for jumping in and explaining our rules of respectful collaboration.

The other point, also worth remembering for everyone:

+-------------------------------------------------------------------------+
| Don't post a patch that combines several different, independent issues. |
+-------------------------------------------------------------------------+

Rationale: Ease of review, and ease of discussion.

In this case the patch included 8 independent topics. Even 2 independent
topics in one patch is too much. Follow Paul's example, who fixed 7 issues
in lib/mktime.c recently, within less than 48 hours, but who was careful
enough to do and commit them one by one.

Bruno
-- 
In memoriam Hatun Sürücü <http://en.wikipedia.org/wiki/Hatun_Sürücü>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]