Re: copy-file.c vs ignoring chown's return value

[Bruno Haible]

Hi Jim,

> * lib/copy-file.c: Include "ignore-value.h".
> (copy_file_preserving): Ignore chown failure.
> * modules/copy-file (Depends-on): Add ignore-value.

Looks all fine, no objection. Thank you.

> One is to add this pragma along with a comment somewhere in copy-file.c:
> 
>     # pragma GCC diagnostic ignored "-Wunused-result"
> 
> but that seems unwise.

Yes, such use of #pragma would make it harder to move code around between
different .c files.

Bruno
-- 
In memoriam Vladislav Listyev <http://en.wikipedia.org/wiki/Vladislav_Listyev>