bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv2] strerror: drop strerror_r dependency


From: Eric Blake
Subject: Re: [PATCHv2] strerror: drop strerror_r dependency
Date: Mon, 06 Jun 2011 14:44:00 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 06/06/2011 02:37 PM, Bruno Haible wrote:
> Eric Blake wrote:
>> both need the overrides, so
>> the overrides have to be AC_LIBOBJ at the first client).
> 
> You can have more than one AC_LIBOBJ invocation of the same file. Duplicates
> removed automatically, cf. gnulib-tool line 3758.

But only if they are both in libs or both in tests.  If you have
strerror in libs and strerror_r in tests, and both try to do AC_LIBOBJ,
then you get into the funky situation where strerror-overrided.c is not
in the tests directory and the build fails.  Compare to the problem we
were solving earlier with fclose vs. fflush being in separate
directories, and the AC_LIBOBJ([fflush]) giving us grief.

Which is why we need a separate module as prereq for both strerror and
strerror_r-posix, so that the AC_LIBOBJ only occurs in one directory
corresponding to where strerror-override.c is placed.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]