[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fseeko, ftello: avoid inline function in include file

From: Eric Blake
Subject: Re: fseeko, ftello: avoid inline function in include file
Date: Mon, 13 Jun 2011 08:49:07 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110419 Red Hat/3.1.10-1.el6_0 Mnenhy/0.8.3 Thunderbird/3.1.10

On 06/13/2011 05:21 AM, Bruno Haible wrote:
> The fix is to move the inline function to non-inline code. Actually 
> lib/ftell.c
> already exists, with the right code.
> The purpose of that inline function, as the comments say, is to ensure ftell()
> is consistent with ftello(). But that can be achieved in a much simpler way:
> through a dependency from module 'ftello' to module 'ftell'. Yes, that's a
> circular dependency, but that is well supported by gnulib (even with
> --conditional-dependencies).
> Eric, you wrote this code on 2009-12-31 (committed on 2010-01-11), and I
> reworked it on 2010-04-03. Any objections to this proposed patch (and likewise
> for fseek and fseeko)? It fixes the problem on Solaris 9.
> 2011-06-13  Bruno Haible  <address@hidden>
>       ftello: Provide a non-inline replacement of ftell().
>       * lib/stdio.in.h (ftell): Don't provide if module 'ftell' is not used.
>       * m4/ftell.m4 (gl_FUNC_FTELL): Replace ftell also if the system does
>       not have ftello() (such as on mingw).
>       * modules/ftello (Depends-on): Add ftell.
>       * modules/ftell (License): Change to LGPLv2+.

This looks reasonable to me (and no problem on the license change).

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]