bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/348] move AC_LIBOBJ invocations to the module descriptions


From: Jim Meyering
Subject: Re: [PATCH 0/348] move AC_LIBOBJ invocations to the module descriptions
Date: Mon, 13 Jun 2011 19:26:56 +0200

Stefano Lattarini wrote:
...
> Maybe this is a stupid question, but why are you removing the
> `sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT' check here
> (and its rules below)?  If this is intended, it should be
> mentioned in the ChangeLog IMHO.

Ouch.  That's two in one day.
I removed it by mistake.  Thanks for catching it.
Here's a fixed version:

>From 4e6fbcee593820350084e364cc6ae86bb95f4565 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 13 Jun 2011 18:01:47 +0200
Subject: [PATCH] syntax-check: add a rule to help enforce the
 no-AC_LIBOBJ-in-m4/ policy

* Makefile (sc_prohibit_AC_LIBOBJ_in_m4): New rule.
---
 ChangeLog |    5 +++++
 Makefile  |   36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 19a3dff..ff58b67 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-06-13  Jim Meyering  <address@hidden>
+
+       syntax-check: add a rule to help enforce the no-AC_LIBOBJ-in-m4/ policy
+       * Makefile (sc_prohibit_AC_LIBOBJ_in_m4): New rule.
+
 2011-06-13  Bruno Haible  <address@hidden>

        gnulib-tool: Addendum to 2011-06-08 commit.
diff --git a/Makefile b/Makefile
index c9bfc16..7c1454a 100644
--- a/Makefile
+++ b/Makefile
@@ -37,6 +37,42 @@ sc_prohibit_augmenting_PATH_via_TESTS_ENVIRONMENT:
                 "  see <$$url>" 1>&2; exit 1; } || :                   \
        else :; fi

+# Files in m4/ that (exceptionally) may use AC_LIBOBJ.
+# Do not include their ".m4" suffix.
+allow_AC_LIBOBJ =      \
+  close                        \
+  dprintf              \
+  dup2                 \
+  faccessat            \
+  fchdir               \
+  fclose               \
+  fcntl                        \
+  fprintf-posix                \
+  open                 \
+  printf-posix         \
+  snprintf             \
+  sprintf-posix                \
+  stdio_h              \
+  vasnprintf           \
+  vasprintf            \
+  vdprintf             \
+  vfprintf-posix       \
+  vprintf-posix                \
+  vsnprintf            \
+  vsprintf-posix
+
+allow_AC_LIBOBJ_or := $(shell echo $(allow_AC_LIBOBJ) | tr -s ' ' '|')
+
+sc_prohibit_AC_LIBOBJ_in_m4:
+       url=http://article.gmane.org/gmane.comp.lib.gnulib.bugs/26995;  \
+       if test -d .git; then                                           \
+         git ls-files m4                                               \
+            | grep -Ev '^m4/($(allow_AC_LIBOBJ_or))\.m4$$'             \
+            | xargs grep -w AC_LIBOBJ                                  \
+           && { printf '%s\n' 'Do not use AC_LIBOBJ in m4/*.m4;'       \
+                "see <$$url>"; exit 1; } || :;                         \
+       else :; fi
+
 sc_pragma_columns:
        if test -d .git; then                                           \
          git ls-files|grep '\.in\.h$$'                                 \
--
1.7.6.rc0.293.g40857



reply via email to

[Prev in Thread] Current Thread [Next in Thread]