[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Enable more syntax checks, eliminate useless C preproces
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/2] Enable more syntax checks, eliminate useless C preprocessor parentheses |
Date: |
Mon, 20 Jun 2011 11:14:52 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 06/18/2011 06:15 PM, Bruno Haible wrote:
> James, Eric,
>> we're trying to get rid of a findutils construct:
>>
>> -#if defined SIGCLD && !defined SIGCHLD
>> -# define SIGCHLD SIGCLD
>> -#endif
>>
>> and need to know if gnulib's replacement <signal.h> needs to guarantee
>> this definition of SIGCHLD, or if the only platforms where only SIGCLD
>> existed are now so old to not be worth worrying about.
>
> As far as I can see, all platforms except native Windows nowadays have
> SIGCHLD.
> - I find it defined in <signal.h> or <sys/signal.h> of all relevant platforms.
> - coreutils/src/{sort.c,timeout.c} use SIGCHLD unconditionally, and I'm not
> aware of a bug report because of that.
Good to know. The findutils patch that triggered this question is
therefore safe.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature