[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint.mk: add syntax-check to avoid char[PATH_MAX]
From: |
Eric Blake |
Subject: |
Re: [PATCH] maint.mk: add syntax-check to avoid char[PATH_MAX] |
Date: |
Thu, 23 Jun 2011 06:42:09 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
On 06/23/2011 06:34 AM, Jim Meyering wrote:
>> +# not be constant, or might overflow a stack. In general, use PATH_MAX as
>> +# a limit, not an array or alloca size.
>> +sc_prohibit_path_max_allocation:
>> + @prohibit='(\balloca *\([^)]*|\[[^]]*)PATH_MAX' \
>> + halt='Avoid allocations of size PATH_MAX' \
>
> That looks fine. Thanks.
>
> Though I'd make one small change:
> s/allocations/stack allocation/
Done and pushed.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature