bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: getting EBADF on MSVC


From: Paul Eggert
Subject: Re: getting EBADF on MSVC
Date: Sun, 25 Sep 2011 09:38:05 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.21) Gecko/20110831 Thunderbird/3.1.13

On 09/25/11 02:30, Bruno Haible wrote:
> It's good and normal programming style to add 'inline' in front of
> all static functions that are only used once in the compilation unit.

This is not a style that I'm familiar with or comfortable with.
It reminds me of people putting "register" in front of declarations.
Typically there's little or no performance benefit,
and sometimes performance even gets worse.
And there's a definite cost to maintenance.

These days it's typically better to let the compiler do its own
optimization, and to intervene manually only when you know
better than the compiler, because you've measured
the benefit in this or in similar circumstances.

However, since the code in question is Windows-specific,
I'll defer to your judgement here.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]