bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] README-release improvements


From: Jim Meyering
Subject: Re: [PATCH] README-release improvements
Date: Fri, 21 Oct 2011 10:17:30 +0200

Gary V. Vaughan wrote:
> I made these changes in gnulib-local/top/README-release while making
> a start at leveraging the gnulib release machinery into GNU Libtool,
> but they seem generally applicable too.

Thanks for the suggestions.
However, it's not quite ready.

> Okay to push?

I'm glad you asked first.
Please do that for every iteration with any file I maintain.

In the future, please post unmodified "git format-patch" output,
precisely so that we can apply and test any such patch.

> +* If you are a @PACKAGE@ maintainer, but have not yet registered your
> +  gpg public key and (preferred) email address with the FSF, send an
> +  email, preferably GPG-signed, to <address@hidden> that includes
> +  the following:
> +
> +    (a) name of package(s) that you are the maintainer for, and your
> +        preferred email address.
> +
> +    (b) an ASCII armored copy of your GnuPG key, as an attachment.
> +       ("gpg --export -a YOUR_KEY_ID > mykey.asc" should give you
> +       this.)
> +
> +  When you have received acknowledgement of your message, the proper GPG
> +  keys will be registered on ftp-upload.gnu.org and only then will you be
> +  authorized to upload files to the FSF ftp machines.

All of the above will be useful exactly once per person/package
and then skipped forever after.  Also, that same information is
already in the maintainer's guide.  Let's not duplicate it.
If anything simply refer to that, e.g.,
https://www.gnu.org/prep/maintain/html_node/Automated-Upload-Registration.html#Automated-Upload-Registration
Though I am leery of adding even a one or two line note at
the very top, when it's something that will be useful so seldom.

> +* If you do not have access to the mailing list administrative interface,
> +  approach the list owners for the password.

This sentence is in the same vein.  Please omit it.

> Be sure to check the lists
> +  (esp. address@hidden@) for outstanding bug reports also in the list of
> +  pending moderation requests.

IMHO, the above is so obvious that it's not worth including.  If you're a
package maintainer and not watching mailing lists then you're not doing
your job.  You should never have to hassle with moderation requests.
If you do, then you should follow the instructions here:

    http://savannah.gnu.org/maintenance/ListHelperAntiSpam

...
> -* Run ./configure && make maintainer-clean
> -

Why do you want to remove the "make maintainer-clean"?
I saw no justification, so maybe it's an accident.

...
> -* Run bootstrap one last time.  This downloads any new translations:
> +* Run "./bootstrap". This downloads any new translations.

Please leave two spaces after each sentence-ending ".".

...
> -    build-aux/do-release-commit-and-tag X.Y stable
> +    ./build-aux/do-release-commit-and-tag X.Y stable

Please drop these "./"-adding changes or include a note in the log saying
which precisely shell motivates the change.  There's certainly no "." in
my PATH and the leading "./" is not needed by bash, zsh, dash, ksh, ash,
csh or tcsh.

...
>  * Send the announcement email message.
> +  Address the email to address@hidden@@gnu.org' and
> +  address@hidden' with the Reply-To header set to
> +  address@hidden@@gnu.org'.  Stable releases should also be announced on
> +  address@hidden'.

Please remove the above hunk.  First, it should not mention autotools.
Though mainly, if the automatically-generated announcement does not include
the headers you want, customize them via cfg.mk, using these variables:

    announcement_Cc_
    announcement_mail_headers_



reply via email to

[Prev in Thread] Current Thread [Next in Thread]