bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint.mk: catch "see @xref{}"


From: Akim Demaille
Subject: Re: [PATCH] maint.mk: catch "see @xref{}"
Date: Tue, 17 Apr 2012 09:04:08 +0200

Hi Jim!

Le 16 avr. 2012 à 23:03, Jim Meyering a écrit :

> +2012-04-16  Akim Demaille  <address@hidden>
> +     and Jim Meyering  <address@hidden>

Thanks for granting me, but I'm not even the "see" and
the "@xref" that remain are from my hand :)

> +see_also_re_ = (?:see(?:\s+also)?|also(?:\s+see)?)

I don't see what it buys to have the second
part.  "also see @xref" is just a longer "see @xref",
which is caught by the first one.  With respect
to "also @xref", if you think this is wrong (and
I concur), then (?:also|see) should suffice.

> +bad_xref_re_ ?= (?:[\w,:;] +|$(see_also_re_)\s+)address@hidden
> +bad_pxref_re_ ?= (?:[.!?]|$(see_also_re_))address@hidden
> prohibit_undesirable_word_seq_RE_ ?=                                  \
> -  /\bcan\s+not\b/gims
> +  /(?:\bcan\s+not\b|$(bad_xref_re_)|$(bad_pxref_re_))/gims
> prohibit_undesirable_word_seq_ =                                      \
>     -e 'while ($(prohibit_undesirable_word_seq_RE_))'                 \
>     $(perl_filename_lineno_text_)
> --
> 1.7.10.169.g146fe




reply via email to

[Prev in Thread] Current Thread [Next in Thread]