bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new module 'system-quote'


From: Eli Zaretskii
Subject: Re: new module 'system-quote'
Date: Sat, 12 May 2012 13:59:10 +0300

> From: Bruno Haible <address@hidden>
> Cc: address@hidden
> Date: Sat, 12 May 2012 11:31 +0200
> 
> Eli Zaretskii wrote:
> > If programs need to call 'glob' before calling 'system' and 'popen'
> > with arguments quoted by this module, that fact should be prominently
> > mentioned in the documentation.
> 
> The programmer needs to invoke glob explicitly if he uses the system-quote
> module *and* wants wildcard expansion. I'm adding a bit of comments to
> make this clear.
> 
> But since gnulib doesn't override system() nor popen(), there is nothing
> to document for these functions.
> 
> Feel free to provide a doc patch if I misunderstood what you meant.

I'd suggest something along these lines in the comments:

  Note that if strings quoted by this module are to be passed to
  'system' or 'popen' and include wildcards, they need to be processed
  by 'glob' before quoting, to get the wildcards expanded rather than
  quoted.

I believe this is pertinent for Windows and Posix platforms alike.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]