[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint.mk: new syntax check for HAVE_DECL checks
From: |
Simon Josefsson |
Subject: |
Re: [PATCH] maint.mk: new syntax check for HAVE_DECL checks |
Date: |
Thu, 19 Jul 2012 12:49:56 +0200 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/23.3 (gnu/linux) |
Bruno Haible <address@hidden> writes:
> Eric Blake wrote:
>> Should we get rid of the
>> sanity checks that use #error when a macro is undefined, in order
>> to reduce the number of exemptions?
>
> I agree, this would be useful for those source files that are always
> taken as an entire module from gnulib. I wouldn't do so for error.c and
> getopt.c, though: these two files are shared with many more packages,
> through manual copying. Also strtoimax.c is a bit complicated (because
> shared among two modules), therefore the check is non-trivial and welcome.
>
> Here are 2 proposed patch. Jim, Simon, OK?
Sure!
/Simon