[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic o
From: |
Eric Blake |
Subject: |
Re: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic ops code |
Date: |
Thu, 19 Jul 2012 08:15:28 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 07/18/2012 07:07 PM, Hu Tao wrote:
> <...>
>
>> +
>> +# define virAtomicIntGet(atomic) \
>> + (__extension__ ({ \
>> + verify (sizeof(*(atomic)) == sizeof(int)); \
>> + (void) (0 ? *(atomic) ^ *(atomic) : 0); \
>> + __sync_synchronize (); \
>> + (int) *(atomic); \
>> + }))
>
> The `verify' lines cause building warnings:
>
> cc1: warnings being treated as errors
> util/virobject.c: In function 'virClassNew':
> util/virobject.c:74:99: error: nested extern declaration of
> '_gl_verify_function2' [-Wnested-externs]
Which version of gcc?
I'll have to see if I can come up with a solution in upstream gnulib
that expands verify() in such a way that works with -Wnested-externs.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [libvirt] [PATCH 03/13] Rewrite virAtomic APIs using GLib's atomic ops code,
Eric Blake <=