[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
stat-time.h vs. -Waggregate-return
From: |
Eric Blake |
Subject: |
stat-time.h vs. -Waggregate-return |
Date: |
Thu, 02 Aug 2012 16:40:57 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
The manywarnings module enables -Waggregate-return, but stat-time.h
provides functions that return a struct timespec value and therefore
trigger this compiler warning.
Would anyone object if I rewrote this header to change the signature of
the various functions from the current:
/* Return *ST's access time. */
static inline struct timespec
get_stat_atime (struct stat const *st)
to the new:
/* Store *ST's access time into *TS. */
static inline void
get_stat_atime (struct stat const *st, struct timespec *ts)
along with a NEWS entry about the API change?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- stat-time.h vs. -Waggregate-return,
Eric Blake <=