bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/9] utimens-tests: avoid unnecessary 'inline'


From: Paul Eggert
Subject: [PATCH 2/9] utimens-tests: avoid unnecessary 'inline'
Date: Wed, 29 Aug 2012 23:22:08 -0700
User-agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0

* modules/fdutimensat-tests (configure.ac):
* modules/futimens-tests (configure.ac):
* modules/utimens-tests (configure.ac):
* modules/utimensat-tests (configure.ac):
Remove AC_C_INLINE.
* tests/test-utimens-common.h (ctime_compare):
No longer inline.  Simplicity and portability trump efficiency here.
---
 ChangeLog                   | 9 +++++++++
 modules/fdutimensat-tests   | 1 -
 modules/futimens-tests      | 1 -
 modules/utimens-tests       | 1 -
 modules/utimensat-tests     | 1 -
 tests/test-utimens-common.h | 2 +-
 6 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index d6c6609..008b565 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,14 @@
 2012-08-27  Paul Eggert  <address@hidden>
 
+       utimens-tests: avoid unnecessary 'inline'
+       * modules/fdutimensat-tests (configure.ac):
+       * modules/futimens-tests (configure.ac):
+       * modules/utimens-tests (configure.ac):
+       * modules/utimensat-tests (configure.ac):
+       Remove AC_C_INLINE.
+       * tests/test-utimens-common.h (ctime_compare):
+       No longer inline.  Simplicity and portability trump efficiency here.
+
        misc: don't limit commentary to inline functions
        * lib/binary-io.h, lib/malloca.h, lib/safe-alloc.c:
        * lib/xalloc-oversized.h, lib/xsize.h:
diff --git a/modules/fdutimensat-tests b/modules/fdutimensat-tests
index c4dc5af..9e3e779 100644
--- a/modules/fdutimensat-tests
+++ b/modules/fdutimensat-tests
@@ -17,7 +17,6 @@ usleep
 utimecmp
 
 configure.ac:
-AC_REQUIRE([AC_C_INLINE])
 
 Makefile.am:
 TESTS += test-fdutimensat
diff --git a/modules/futimens-tests b/modules/futimens-tests
index 1b72de5..ff98019 100644
--- a/modules/futimens-tests
+++ b/modules/futimens-tests
@@ -15,7 +15,6 @@ usleep
 utimecmp
 
 configure.ac:
-AC_REQUIRE([AC_C_INLINE])
 
 Makefile.am:
 TESTS += test-futimens
diff --git a/modules/utimens-tests b/modules/utimens-tests
index 802d8e5..4d5d1f5 100644
--- a/modules/utimens-tests
+++ b/modules/utimens-tests
@@ -16,7 +16,6 @@ usleep
 utimecmp
 
 configure.ac:
-AC_REQUIRE([AC_C_INLINE])
 
 Makefile.am:
 TESTS += test-utimens
diff --git a/modules/utimensat-tests b/modules/utimensat-tests
index ec426bb..6acfe89 100644
--- a/modules/utimensat-tests
+++ b/modules/utimensat-tests
@@ -14,7 +14,6 @@ usleep
 utimecmp
 
 configure.ac:
-AC_REQUIRE([AC_C_INLINE])
 
 Makefile.am:
 TESTS += test-utimensat
diff --git a/tests/test-utimens-common.h b/tests/test-utimens-common.h
index d1fb0f4..6fe8465 100644
--- a/tests/test-utimens-common.h
+++ b/tests/test-utimens-common.h
@@ -59,7 +59,7 @@ enum {
 
 /* Compare two st_ctime values.  Return -1, 0 or 1, respectively
    when A's st_ctime is smaller than, equal to or greater than B's.  */
-static inline int
+static int
 ctime_compare (struct stat const *a, struct stat const *b)
 {
   if (a->st_ctime < b->st_ctime)
-- 
1.7.11.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]